Skip to content

Prefer os.path.samefile() for checkpoint file distinctness test #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolandwalker wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Prefer os.path.samefile() for checkpoint file distinctness test #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Internal
* Improve test coverage for DSN variable expansion.
* Test on all platforms in the Publish GitHub Action.
* Remove unused support for writing `.mylogin.cnf` files.
* Prefer `os.path.samefile()` for checkpoint distinctness test.


1.76.0 (2026/06/20)
Expand Down
2 changes: 1 addition & 1 deletion mycli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ def preprocess_cli_args(
and cli_args.batch != '-'
and os.path.exists(cli_args.batch)
):
if os.stat(cli_args.batch) == os.stat(cli_args.checkpoint):
if os.path.samefile(cli_args.batch, cli_args.checkpoint):
click.secho('Error: --batch and --checkpoint must be different files.', err=True, fg='red')
sys.exit(1)

Expand Down
Loading