Ensure --batch and --logfile are distinct files#1962
Merged
Conversation
scottnemes
reviewed
Jun 24, 2026
| and cli_args.batch != '-' | ||
| and os.path.exists(cli_args.batch) | ||
| ): | ||
| if os.stat(cli_args.batch) == os.stat(cli_args.logfile.name): |
Contributor
There was a problem hiding this comment.
Recommended way of checking if two files are the same file is os.path.samefile. Looks like we use os.stat directly elsewhere so it matches, but would be worth at least using it for new stuff
scottnemes
approved these changes
Jun 24, 2026
scottnemes
left a comment
scottnemes
left a comment
Contributor
There was a problem hiding this comment.
Left one nit, but fine to merge either way
Motivation: to avoid some kind of infinite loop, in which mycli reads from a file which is constantly being written to.
rolandwalker
force-pushed
the
RW/ensure-distinct-batch-logfile
branch
from
f3da90e to
9533565
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation: to avoid some kind of infinite loop, in which mycli reads from a file which is constantly being written to.
This is much more succinct than #1931 , which changed the argument type from a file to a string. In retrospect that change was a mistake.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).