mcg: fix ha16/lo16 far data, O_CREAT; adjust mcg spills#372
Merged
davidgiven merged 1 commit intoJul 18, 2026
Conversation
Allow ha16/lo16 for locals past 64K via symbol relative relocations with linker handling of module local names. Define MIPS compatible O_CREAT correctly. Fail (and don't crash) in mcg when a stacked spill is still insn operand. Signed-off-by: Jeffrey H. Johnson <johnsonjh.dev@gmail.com>
Contributor
Author
|
@davidgiven have a chance to review this yet? It still isn’t “perfect” but its definitely an improvement. |
Owner
|
Looks great, thank you! Of course MIPS uses different open() parameters to anything else; being standardised would be convenient... What's the change to led/relocate.c for? |
Contributor
Author
|
kind of a workaround to let the new ha16 overflow handling get resolved by the linker (resolving against the section+offset instead of needing to expose these locals globally and then do name mangling or what not) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ha16/lo16for locals past 64K via symbol relative relocations with linker handling of module local names.O_CREATcorrectly.mcgwhen a stacked spill is still an insn operand.Closes #371