feat: Added fast hot patch for getColumn#3
Open
dvmoritzschoefl wants to merge 1 commit into
Open
Conversation
puehringer
reviewed
Jun 13, 2026
Comment on lines
+336
to
+342
| columnsById = table.getAllFlatColumns().reduce( | ||
| (acc, column) => { | ||
| acc[column.id] = column | ||
| return acc | ||
| }, | ||
| {} as Record<string, Column<TData, unknown>> | ||
| ) |
There was a problem hiding this comment.
Why is this not using table._getAllFlatColumnsById()[columnId]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Further:
The sorting function is actually very bad and can improved a lot (maybe in v9?). Just as an example:
calls the value getters again. mabye a "pre sort" value cache would be an option?