Productionise masque-bricks + reposition README#1
Open
carlosfunk wants to merge 4 commits into
Open
Conversation
carlosfunk
changed the title
carlosfunk
force-pushed
the
dm-3824-productionise
branch
from
July 14, 2026 02:17
f4e4def to
d0ea18c
Compare
carlosfunk
marked this pull request as ready for review
July 14, 2026 02:29
- reframe the README around native Databricks masking as the default, with masque-bricks as the retained out-of-place option
- lead with the value proposition ("synthetically identical customer data") plus learn-more and demo links
- link the native Databricks masking docs and canonicalise the documentation URLs
- add SECURITY.md with a private vulnerability-disclosure path
- normalise the LICENSE to canonical Apache 2.0 text with "DataMasque Ltd" as copyright holder
- use obvious placeholders in the example config and document the OAuth and verify_ssl options
- run pytest via uv on pushes to main and on pull requests
- quote and validate SQL identifiers, formats, and S3 paths to remove f-string injection - make TLS verification configurable and default-secure, suppressing warnings only when explicitly opted out - give run and mask distinct connection names so neither can mask the wrong prefix - retry idempotent DataMasque calls with backoff and tolerate transient errors while polling a run - stop printing the client id and fix the client_id[:8] TypeError during check - use UTC timestamps for S3 path segments and drop dead S3 helpers and unused format flexibility - mask sample-ruleset PII columns with DataMasque built-in seed files for realistic output
- add unit tests for config loading, connection naming, SQL quoting, and the DataMasque client - add s3_uri slash-normalisation tests - declare pytest as a dev optional-dependency and lock it
carlosfunk
force-pushed
the
dm-3824-productionise
branch
from
July 14, 2026 02:42
d0ea18c to
62e0468
Compare
jiatolentino
suggested changes
Jul 16, 2026
Comment on lines
+36
to
+38
| slug = "_".join(p for p in (bucket, base_directory.strip("/")) if p) | ||
| safe = "".join(c if c.isalnum() else "_" for c in slug) | ||
| return f"masque_bricks_{role}_{safe}" |
There was a problem hiding this comment.
/, -, _ all slug to _, so raw/users and raw-users get the same connection name, which is the wrong-prefix reuse this was meant to prevent. Maybe worth tightening?
Comment on lines
71
to
73
| ```bash | ||
| pip install -e . | ||
| masque-bricks --help |
There was a problem hiding this comment.
pip install -e . ignores uv.lock and the >= floors can pull breaking majors. Have we considered dropping it for uv sync?
| ) | ||
| adapter = HTTPAdapter(max_retries=retry) | ||
| self.session.mount("https://", adapter) | ||
| self.session.mount("http://", adapter) |
There was a problem hiding this comment.
connect inherits total, so check now sits for ~14s before it reports a down instance. Would it be better to set connect=0 to let it fail fast while polling keeps the retries?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates masque-bricks and repositions its README for public, self-served use.
Hardening:
verify_sslconfigurable + default-secure; stop blanket warning suppression.client_id[:8]TypeError; stop printing client_id.Repositioning: native Databricks masking presented as recommended default; masque-bricks framed as the retained out-of-place Delta pipeline.