feat: add preview to html form - #22
Conversation
There was a problem hiding this comment.
LGTM
But are we sure we can already merge on master ? If this is release before https://github.com/dataiku/dip/pull/49876 and installed in the DSS it will not going to work until dss support EMAIL_TEMPLATE_TEXTAREA
Co-authored-by: Axel Messinese <axel.messinese@dataiku.com>
|
Thanks for the implementation and review @colincazabet @amessines I suggest to wait for this PR to be merged before considering to merge this one. |
amessines
left a comment
amessines
left a comment
There was a problem hiding this comment.
So we did validate in EAL meeting the changes
Maybe we should bump to 2.0.0 instead of 1.1.0 ? But it could be done in other PR related to html preview.
…23) * feature: support preview of jinja variables + dataiku variables (project and global) * fix: use dataiku.default_project_key * fix: remove dku variables expansion in form * doc: specify that preview only renders first row of contacts * fix: possible crash when no attachment dataset * fix: return error when missing variable * fix: get html from config
Co-authored-by: Gregory Ssi-Yan-Kai <2707931+gssiyankai@users.noreply.github.com>
|
@gssiyankai should i merge this now ? i don't see any blocker on my side |
|
if we merge now, it means it will be in the next release |
3 participants
No description provided.