Skip to content

fix: Fix MCP oid missing validation #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiaJunjie2020 merged 1 commit into from
Jun 11, 2026
Merged

fix: Fix MCP oid missing validation #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/apps/mcp/mcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ async def datasource_list(session: SessionDep, trans: Trans, mcp_ds: McpDs):
w_list = await user_ws_options(session, session_user.id, trans)
oid_list = [item.id for item in w_list]
if int(mcp_ds.oid) not in oid_list:
raise HTTPException(status_code=400, detail="This user not in current workspace")
raise HTTPException(status_code=400, detail="The current user is not in the selected workspace")

session_user.oid = int(mcp_ds.oid)
ds_list = get_datasource_list(session=session, user=session_user)
Expand Down Expand Up @@ -143,7 +143,7 @@ async def mcp_question(session: SessionDep, trans: Trans, chat: McpQuestion):
w_list = await user_ws_options(session, session_user.id, trans)
oid_list = [item.id for item in w_list]
if int(chat.oid) not in oid_list:
raise HTTPException(status_code=400, detail="This user not in current workspace")
raise HTTPException(status_code=400, detail="The current user is not in the selected workspace")

session_user.oid = int(chat.oid)
ds_id: Optional[int] = None
Expand Down
Loading