Skip to content

fix sql validator BIS_CentralBankPolicyRate#2095

Open
niveditasing wants to merge 1 commit into
datacommonsorg:masterfrom
niveditasing:bis_fresh_goldens
Open

fix sql validator BIS_CentralBankPolicyRate#2095
niveditasing wants to merge 1 commit into
datacommonsorg:masterfrom
niveditasing:bis_fresh_goldens

Conversation

@niveditasing

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the validation configuration by replacing variableMeasured with StatVar in SQL queries and switching the deletion validator from DELETED_RECORDS_COUNT to DELETED_RECORDS_PERCENT with a threshold of 0.1. The reviewer pointed out that the DELETED_RECORDS_PERCENT validator uses a 0-100 scale, meaning a threshold of 0.1 restricts deletions to 0.1% instead of 10%. They suggested adjusting the threshold to 10 if a 10% limit was intended.

"validator": "DELETED_RECORDS_PERCENT",
"params": {
"threshold": 100
"threshold": 0.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The DELETED_RECORDS_PERCENT validator calculates the percentage of deleted records on a scale of 0 to 100 (i.e., (deleted_obs_count / previous_obs_count) * 100). Setting the threshold to 0.1 restricts deletions to 0.1% (1 in 1000 records). If the intention was to set a threshold of 10%, this should be set to 10.

Suggested change
"threshold": 0.1
"threshold": 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant