fix sql validator BIS_CentralBankPolicyRate#2095
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the validation configuration by replacing variableMeasured with StatVar in SQL queries and switching the deletion validator from DELETED_RECORDS_COUNT to DELETED_RECORDS_PERCENT with a threshold of 0.1. The reviewer pointed out that the DELETED_RECORDS_PERCENT validator uses a 0-100 scale, meaning a threshold of 0.1 restricts deletions to 0.1% instead of 10%. They suggested adjusting the threshold to 10 if a 10% limit was intended.
| "validator": "DELETED_RECORDS_PERCENT", | ||
| "params": { | ||
| "threshold": 100 | ||
| "threshold": 0.1 |
There was a problem hiding this comment.
The DELETED_RECORDS_PERCENT validator calculates the percentage of deleted records on a scale of 0 to 100 (i.e., (deleted_obs_count / previous_obs_count) * 100). Setting the threshold to 0.1 restricts deletions to 0.1% (1 in 1000 records). If the intention was to set a threshold of 10%, this should be set to 10.
| "threshold": 0.1 | |
| "threshold": 10 |
No description provided.