chore: raise dbt-common upper bound to <1.39.0 - #1630
Merged
Conversation
Unlocks dbt-common 1.38.0, which fixes a mashumaro>=3.15 bool
deserialization regression (bool("false") -> True).
itsnamangoyal
requested review from
jprakash-db,
saishreeeee and
sd-db
as code owners
August 11, 2026 05:59
sd-db
changed the title
Collaborator
|
/integration-test |
|
Integration tests dispatched for PR #1630 by @sd-db. Testing commit ca983a1. Track progress in the Actions tab. |
|
Integration results for PR #1630 — UC cluster ✅ success · SQL warehouse ✅ success · All-purpose cluster ✅ success · Shard coverage ✅ success |
sd-db
enabled auto-merge (squash)
August 11, 2026 08:33
sd-db
approved these changes
Aug 11, 2026
sd-db
left a comment
sd-db
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good, thanks for the PR !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbt-commonupper bound from<1.38.0to<1.39.0, unlockingdbt-common==1.38.0.dbt-common==1.38.0includesUncoercedBoolSerialization, which fixes amashumaro>=3.15regression where the bool deserializer does a naive truthy cast (bool("false") -> True) instead of raising on invalid input. That regression currently causes several config-validation checks (invalidenabled, malformed exposure/metric/source config) to silently accept bad values instead of raising.uv lock --upgrade-package dbt-commonto bump the pinned lock version alongside the bound, per the contributing guide.Test plan
uv lock --checkpasses (lock and pyproject are consistent)