Skip to content

fix(ide): assert the contract NewBridge actually has #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snider merged 1 commit into from
Aug 8, 2026
Merged

fix(ide): assert the contract NewBridge actually has #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion go/pkg/mcp/ide/bridge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,18 @@ func TestBridge_NewBridge_Good(t *T) {
func TestBridge_NewBridge_Bad(t *T) {
bridge := NewBridge(nil, Config{})
AssertNil(t, bridge.hub)
AssertEqual(t, "", bridge.cfg.LaravelWSURL)

// A zero Config must come back defaulted, not raw. This asserted "" until
// now, which was the behaviour before NewBridge started calling
// WithDefaults — the test kept the old contract while the fix that
// introduced defaults went in without it. A raw Config leaves
// ReconnectInterval at 0, and connectLoop's min(delay*2, max) backoff stays
// pinned at zero, which is a tight reconnect flood: the exact thing that
// change existed to stop.
AssertEqual(t, "ws://localhost:9876/ws", bridge.cfg.LaravelWSURL)
AssertEqual(t, ".", bridge.cfg.WorkspaceRoot)
AssertTrue(t, bridge.cfg.ReconnectInterval > 0)
AssertTrue(t, bridge.cfg.MaxReconnectInterval > 0)
}

// moved AX-7 triplet TestBridge_NewBridge_Ugly
Expand Down
Loading