Pin the Homebrew installer to a commit SHA (dev#99) - #100
Merged
Conversation
The bootstrap script piped Homebrew/install's HEAD to bash inside every image build — third-party code on a mutable ref an upstream compromise could repoint. Pin to the current commit; the repo publishes no tags, and a stale pin fails benign (it still installs current Homebrew). dev's own fetches stay unpinned by design: the script curl from main is review-gated (org ruleset: PR + 1 review, no force-push, bot bypass removed), and the brew formula already checksums each release tarball. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the rescoped #99 (part of d3mlabs/plans#5, audit Gap 9).
Homebrew/installfetch inbin/docker-install-build-deps.shto commit2417318(current HEAD, 2026-08-05) instead of the mutableHEADref. This is third-party code piped to bash inside every image build; a repointed ref would execute inside images that later run on the box and dev Macs. Homebrew/install publishes no tags, so the pin is a commit SHA — bumped deliberately, and a stale pin fails benign (it still installs current Homebrew).Deliberately unpinned (the rescope): dev's own fetches. The consumer curl of this script from
mainis review-gated — org ruleset requires PR + 1 approving review with no force-push/deletion, and the ai-flow bot's bypass was removed — which is the same trust model as ai-flow's@mainreusable workflows, and it preserves auto-deploy. Thebrew install d3mlabs/d3mlabs/devpath already checksums each release tarball via the formula.Test plan
set -euo pipefailbehavior unchangedMade with Cursor