Show proper error message when trying to visualize pseudo scopes#3290
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d508aadad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return { | ||
| start(scopeType: ScopeType, visualizationType: VisualizationType) { | ||
| if (isPseudoScope(scopeType)) { |
There was a problem hiding this comment.
When the requested scope is {type: "interior"}, this guard now throws because isPseudoScope includes interior in pseudoScopes. Unlike instance/className/functionName, interior has a real handler (ScopeHandlerFactoryImpl has a dedicated case "interior" backed by language @interior captures), so cursorless.showScopeVisualizer for interior content/removal no longer works for custom spoken forms or contributor debugging even though the renderer can handle it. Exclude interior from this visualizer guard and only reject pseudo scopes without handlers.
Useful? React with 👍 / 👎.
1 participant
No description provided.