Skip to content

Basic model inference - #48

Merged
Zain-Mahmoud merged 10 commits into
mainfrom
basic-model-inference
Aug 13, 2026
Merged

Basic model inference#48
Zain-Mahmoud merged 10 commits into
mainfrom
basic-model-inference

Conversation

@Zain-Mahmoud

@Zain-Mahmoud Zain-Mahmoud commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This PR aims to implement the model interface to be used to create, load and use inference models.

Validation

  • scripts/quality-check.sh passes locally
  • Appropriate /test commands were run and are passing (e.g. /test gpu)
  • Unit tests were added / e2e tests were added where applicable
  • Manual testing, if applicable (describe further):

Checklist

  • The change is focused and easy to review.
  • Tests were added or updated for behaviour changes.
  • No secrets, generated files, or files that only make sense on my machine are included.
  • Relevant documentation is updated.

Additional Comments

@Zain-Mahmoud Zain-Mahmoud linked an issue Aug 11, 2026 that may be closed by this pull request
Basic Model Inference #16
Closed
@Zain-Mahmoud

Zain-Mahmoud commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Tests passed

  • Groups run: python, slow, web
  • Commit tested: 27f7362
  • Full log: Actions run
Group Result
python 36/36 passed
slow 0/0 passed
web 1/1 passed

@Zain-Mahmoud
Zain-Mahmoud requested a review from KurbyDoo August 11, 2026 22:33
KurbyDoo
KurbyDoo requested changes Aug 12, 2026
View reviewed changes
Comment thread src/terrain_diffusion/inference.py Outdated
Comment thread src/terrain_diffusion/inference.py Outdated
Comment thread tests/test_inference.py Outdated
@Zain-Mahmoud

Zain-Mahmoud commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tests passed

  • Groups run: python, slow, web
  • Commit tested: a9b088c
  • Full log: Actions run
Group Result
python 37/37 passed
slow 0/0 passed
web 1/1 passed

@Zain-Mahmoud
Zain-Mahmoud requested a review from KurbyDoo August 12, 2026 13:08
KurbyDoo
KurbyDoo approved these changes Aug 12, 2026
View reviewed changes

@KurbyDoo KurbyDoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you also link to the relevant sub tickets this change is for?

Comment thread src/terrain_diffusion/inference.py Outdated
Comment thread src/terrain_diffusion/inference.py Outdated
Comment thread tests/test_inference.py Outdated
Comment thread src/terrain_diffusion/inference.py
This was linked to issues Aug 12, 2026
Determine patch shape #17
Closed
Create model harness + Mock model #18
Closed
Load a model by name #19
Closed
Create the mock core model and mock decoder #49
Closed
@Zain-Mahmoud

Zain-Mahmoud commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tests passed

  • Groups run: python, slow, web
  • Commit tested: 1ea31b2
  • Full log: Actions run
Group Result
python 37/37 passed
slow 0/0 passed
web 1/1 passed

@Zain-Mahmoud
Zain-Mahmoud requested a review from KurbyDoo August 12, 2026 20:59
KurbyDoo
KurbyDoo approved these changes Aug 12, 2026
View reviewed changes

@KurbyDoo KurbyDoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably good to merge, just a few nits

Comment thread src/terrain_diffusion/inference.py
Comment thread tests/test_inference.py
@Zain-Mahmoud
Zain-Mahmoud requested a review from KurbyDoo August 13, 2026 09:17
@Zain-Mahmoud

Zain-Mahmoud commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

Tests passed

  • Groups run: python, slow, web
  • Commit tested: 0e95895
  • Full log: Actions run
Group Result
python 41/41 passed
slow 0/0 passed
web 1/1 passed

KurbyDoo
KurbyDoo reviewed Aug 13, 2026
View reviewed changes

@KurbyDoo KurbyDoo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks, just resolve all comments then merge

@Zain-Mahmoud
Zain-Mahmoud merged commit 295f55d into main Aug 13, 2026
3 checks passed
@Zain-Mahmoud
Zain-Mahmoud deleted the basic-model-inference branch August 13, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KurbyDoo KurbyDoo KurbyDoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create the mock core model and mock decoder Load a model by name Create model harness + Mock model Determine patch shape Basic Model Inference

2 participants

@Zain-Mahmoud @KurbyDoo