Docs: Add FLOAT_VECTOR overview example - #298
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
florinutz
left a comment
There was a problem hiding this comment.
Thank you!
The extra, the refresh, and the vector-type anchor all look right, and I confirmed the example returns [('example',)] against a live CrateDB. One thing left from my "link to its anchor" comment: I meant the type table in docs/data-types.rst. The float_vector row is still the only extension type there that isn't clickable: could you make it match the others?
|
Addressed in 767ac12: the FloatVector row in the type table now links to the existing FloatVector anchor and is labeled consistently with the other extension types. Documentation HTML build and linkcheck both pass. |
bgunebakan
left a comment
There was a problem hiding this comment.
Thank you, look like @florinutz comments already addressed with your last commit.
Fixes #190
Adds a focused
FloatVectorexample to the feature overview showing how to define an embedding column, store a vector, and build aknn_matchquery. It also links to the complete vector guide and updates the extension-type introduction so it no longer implies the dialect has only two extension types.Testing
make html(passed)make linkcheck(the new internal cross-reference passes; the command remains nonzero on two unrelated pre-existing GitHub URLs returning 404)git diff --check(passed)