Skip to content

Tests: Remove obsolete Python version skips - #296

Closed
nightcityblade wants to merge 1 commit into
crate:mainfrom
nightcityblade:fix/issue-271
Closed

Tests: Remove obsolete Python version skips#296
nightcityblade wants to merge 1 commit into
crate:mainfrom
nightcityblade:fix/issue-271

Conversation

@nightcityblade

Copy link
Copy Markdown
Contributor

Fixes #271

Summary

  • remove obsolete Python 3.7 skip conditions now that the project requires Python 3.10+
  • retain the relevant SQLAlchemy, pandas, Dask, and Python 3.13 compatibility guards
  • allow the DataFrame doctest coverage to run on every supported Python version

Validation

  • uv run poe lint
  • uv run pytest -q tests/bulk_test.py (2 passed, 3 skipped)
  • tests/test_support_pandas.py against CrateDB 6.5.0 (5 passed)
  • tests/integration.py against CrateDB 6.5.0 (6 passed)

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69bd71e6-8fbc-46d7-80cd-197a557a9012

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@florinutz florinutz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, and thank you for the contribution!

please also have a look at tests/vector_test.py:147, pyproject.toml:81-85 and docs/dataframe.rst:60-61

@nightcityblade

Copy link
Copy Markdown
Contributor Author

Replacement PR: #299

During follow-up, an amend in a shallow clone briefly disconnected this source branch, causing GitHub to auto-close the PR. I rebuilt the change from current upstream main on a fresh branch, preserved the reviewed changes, applied the requested follow-ups, and reran validation. Apologies for the disruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove skipped tests for Python < 3.11

3 participants