Skip to content

Fix grand-central hostname corruption when cluster name recurs in external DNS - #888

Open
tomach wants to merge 1 commit into
masterfrom
ta/fix-gc-hostname-collision
Open

Fix grand-central hostname corruption when cluster name recurs in external DNS#888
tomach wants to merge 1 commit into
masterfrom
ta/fix-gc-hostname-collision

Conversation

@tomach

@tomach tomach commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

The grand-central hostname derivation used an unbounded str.replace() to insert the .gc label, so a cluster name that recurs later in its external DNS (e.g. us-west in region us-west-2) got rewritten everywhere, producing a broken hostname. It now replaces only the first (leading-label) occurrence, which is safe because external_dns is always <cluster_name>.<region>.<domain>.

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/3065
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach
tomach requested review from juanpardo and plaharanne August 18, 2026 15:05

@plaharanne plaharanne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants