Fix grand-central hostname corruption when cluster name recurs in external DNS - #888
Open
tomach wants to merge 1 commit into
Open
Fix grand-central hostname corruption when cluster name recurs in external DNS#888tomach wants to merge 1 commit into
tomach wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The grand-central hostname derivation used an unbounded
str.replace()to insert the.gclabel, so a cluster name that recurs later in its external DNS (e.g.us-westin regionus-west-2) got rewritten everywhere, producing a broken hostname. It now replaces only the first (leading-label) occurrence, which is safe becauseexternal_dnsis always<cluster_name>.<region>.<domain>.Checklist
CHANGES.rst