Require stable cluster health before advancing a rolling restart - #887
Open
tomach wants to merge 2 commits into
Open
Require stable cluster health before advancing a rolling restart#887tomach wants to merge 2 commits into
tomach wants to merge 2 commits into
Conversation
tomach
marked this pull request as ready for review
August 18, 2026 09:20
plaharanne
reviewed
Aug 19, 2026
plaharanne
approved these changes
Aug 19, 2026
plaharanne
left a comment
Contributor
There was a problem hiding this comment.
I've added one note about a comment but except that, it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The rolling-restart health gate (
is_cluster_healthy) decided it was safe to kill the next node from a single snapshot ofsys.nodesandsys.health. Node membership becomes visible before the master finishes recomputing cluster health, so there is a short window where the count is back andsys.healthstill reports a staleGREEN.Now it requires the same healthy reading to hold across N consecutive checks before returning healthy. Configurable via
HEALTH_CHECK_STABILITY_CHECKS(default 3) andHEALTH_CHECK_STABILITY_DELAY(default 2s)Checklist
CHANGES.rst