release(vscode): ship cross-theme icon in 0.1.6 - #73
Merged
Conversation
forhappy
marked this pull request as ready for review
July 27, 2026 23:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currentColorso VS Code controls it across light, dark, and high-contrast themescompass-light.svgandcompass-dark.svgvariants, which were not selected by the Activity Bar contribution0.1.2to0.1.6Why
The Visual Studio Marketplace accepts one static extension PNG and does not select separate light and dark assets. The previous transparent navy mark worked on light surfaces but nearly disappeared on the Marketplace dark theme.
The new
#5865F2tile supplies its own background: it has a 4.61:1 contrast ratio against white and 3.62:1 against the common#1E1E1Edark surface. The white compass mark has 4.61:1 contrast against the tile.Impact
crabbuild.crabbuild-compass-vscodecrabbuild-compass-vscode-0.1.6.vsixVerification
icon.pngis 128×128 and visually inspected it on light and dark backgroundsnpm run typecheck -w editors/vscodenpm test -w editors/vscode— 24 files and 61 tests passednpm run package -w editors/vscodenpm run smoke:vsix -w editors/vscode0.1.6and the expected icon pathsgit diff --checknpm cireports six existing dependency advisories (one low, five high); this PR does not change dependencies.Per project-owner direction, the Graphify codegraph was not refreshed.