fix: migrate parser::read(Stream&, MB) to consuming_buffers#276
Merged
mvandeberg merged 1 commit intoJul 22, 2026
Merged
Conversation
This overload still used the removed buffer_slice().data()/remove_prefix() API. It slipped past the build because it is an uninstantiated template (all tests drive read() with a WriteSink, a different overload). Add testReadBuffers, which instantiates it with a real MutableBufferSequence so the gap cannot reopen.
|
An automated preview of the documentation is available at https://276.http.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-07-22 18:44:55 UTC |
|
GCOVR code coverage report https://276.http.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-07-22 18:59:39 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overload still used the removed buffer_slice().data()/remove_prefix() API. It slipped past the build because it is an uninstantiated template (all tests drive read() with a WriteSink, a different overload).
Add testReadBuffers, which instantiates it with a real MutableBufferSequence so the gap cannot reopen.