Skip to content

Remove unconditional IPO disable on boost_capy#366

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/cmake-flags
Jul 20, 2026
Merged

Remove unconditional IPO disable on boost_capy#366
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/cmake-flags

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

The block forced INTERPROCEDURAL_OPTIMIZATION off on every platform to work around an MSVC LNK2016, but CMake never enables IPO by default, so it only fired when a consumer opted into LTO -- and then it opted capy out on GCC/Clang too, where the linker bug does not exist. Remove it and let CI show whether current MSVC still fails with IPO enabled.

See #361.

The block forced INTERPROCEDURAL_OPTIMIZATION off on every platform to
work around an MSVC LNK2016, but CMake never enables IPO by default, so
it only fired when a consumer opted into LTO -- and then it opted capy
out on GCC/Clang too, where the linker bug does not exist. Remove it and
let CI show whether current MSVC still fails with IPO enabled.

See cppalliance#361.
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://366.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-07-20 15:17:09 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://366.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://366.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://366.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-07-20 15:33:36 UTC

@sgerbino
sgerbino merged commit fe73d8a into cppalliance:develop Jul 20, 2026
36 checks passed
@sgerbino
sgerbino deleted the pr/cmake-flags branch July 20, 2026 15:48
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.18%. Comparing base (49b2db9) to head (4b00c8e).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #366   +/-   ##
========================================
  Coverage    98.18%   98.18%           
========================================
  Files          152      152           
  Lines         8246     8246           
========================================
  Hits          8096     8096           
  Misses         150      150           
Flag Coverage Δ
linux 98.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b2db9...4b00c8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants