[mdspan.sub.helpers] Fix swapped offset/extent in canonical-slice#9139
Open
abhinavagarwal07 wants to merge 1 commit into
Open
[mdspan.sub.helpers] Fix swapped offset/extent in canonical-slice#9139abhinavagarwal07 wants to merge 1 commit into
abhinavagarwal07 wants to merge 1 commit into
Conversation
The extent_slice branch of canonical-slice initializes .offset from s.extent and .extent from s.offset, reversing the intended mapping. This is inconsistent with canonical-range-slice and the pre-P3982R2 wording, both of which map offset → offset and extent → extent.
Member
|
I'm not sure whether this is editorial. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2026/p3982r2.html does have this problem. Does this require an LWG issue or can we treat this as an obvious typo @jwakely |
eisenwave
added
the
P1-Important
Contributor
Author
|
Happy to file LWG if its more appropriate. |
Member
https://github.com/cplusplus/draft/wiki/How-to-tell-if-an-issue-is-editorial This seems clearly editorial, the intended meaning is to initialize the offset with the offset and the extent with the extent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
extent_slicebranch ofcanonical-slice([mdspan.sub.helpers]) initializes.offsetfroms.extentand.extentfroms.offset, reversing the intended mapping. This is inconsistent withcanonical-range-sliceand the pre-P3982R2 wording, both of which map offset → offset and extent → extent.