Migrate the config directory from ~/.config/toolbox to ~/.config/toolbx#1812
Migrate the config directory from ~/.config/toolbox to ~/.config/toolbx#1812ymcx wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the configuration directory path from 'toolbox' to 'toolbx' and introduces a migration step in 'profile.d/toolbox.sh' to move the old configuration directory to the new location. Additionally, it updates the test helper scripts to use '$XDG_CONFIG_HOME' instead of '$HOME/.config'. Feedback was provided regarding the migration script using non-POSIX syntax, which violates Shellcheck, and the potential for terminal clutter due to unredirected errors. Crucially, the migration is incomplete as the Go codebase still references the old path.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
This PR applies the patches I wrote and shared in #1769.
The first commit replaces $HOME/.config with $XDG_CONFIG_HOME in test/system/libs/helpers.bash, as suggested in #1769 (comment). This should've been part of that PR, but I forgot to include it and wasn't able to add it before the PR was merged.
The second commit just replaces ~/.config/toolbox with ~/.config/toolbx. Additionally, the migration is done by first checking whether a directory exists at the old location and if there isn't anything at the new location. If both of these conditions evaluate to true, the old directory is moved to the new location.
It should be stated that there were some issues with the migration as discussed in #1769 (comment). However, I wasn't able to reproduce the issue any longer and instead the migration worked flawlessly, with containers created on the original build working just fine after updating to a build with this PR applied.