refactor: speed up pre-commit hooks - #2756
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2756 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 509 509
Lines 52263 52264 +1
=======================================
+ Hits 49020 49023 +3
+ Misses 3243 3241 -2
🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes some pre-commit hooks, updates auto-generated sync API code for entity matching, and configures new Ruff linting rules. Feedback points out that the added 'T10' rule is redundant because 'T' is already selected, and that a '# TODO' comment should be moved after the docstring to follow standard practices.
| T_ContextualizationJob = TypeVar("T_ContextualizationJob", bound=ContextualizationJob) | ||
|
|
There was a problem hiding this comment.
I wonder why this was added? Another bug in the auto-gen script perhaps 😅 If it is unused, feel free to just delete the lines (and keep diff so it wont be auto-generated immediately again)
There was a problem hiding this comment.
The same typevar is defined in the async api. In both palces it is unclear to me if they are used for anything internal, but since they are public they might be used by external users I assume.
| ... description="AssetMatchingJob1", | ||
| ... ) | ||
| """ | ||
| # TODO: Not in service contract |
There was a problem hiding this comment.
@olacognite could you verify these TODO comments are still needed?
2 participants
Description
The two pre-commit hooks from the pre-commit-hooks package have been replaced.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.