Skip to content

build: attach javadoc jar to release builds#6

Merged
marevol merged 1 commit into
mainfrom
build/attach-javadoc-jar
Jun 11, 2026
Merged

build: attach javadoc jar to release builds#6
marevol merged 1 commit into
mainfrom
build/attach-javadoc-jar

Conversation

@marevol

@marevol marevol commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Release builds did not generate javadoc jars because maven-javadoc-plugin in the root pluginManagement had no jar goal execution, while the core and toolkit modules only declare the plugin without executions. The super POM release-profile that used to handle this is no longer available in current Maven versions, so publishing to Maven Central fails validation during mvn release:perform. Sources jars were already covered by the existing maven-source-plugin execution.

Changes Made

  • Add an attach-javadocs execution (jar goal) to maven-javadoc-plugin in the root pluginManagement, which the core and toolkit modules inherit

Testing

  • Ran mvn package -DskipTests -pl core and confirmed that java-saml-core-*-javadoc.jar is generated alongside the sources jar

Additional Notes

@marevol marevol merged commit 25bb835 into main Jun 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant