fix: use dynamic lockMaxRetries limit in RedisHandler#10295
Open
gr8man wants to merge 9 commits into
Open
Conversation
michalsn
reviewed
Jun 10, 2026
michalsn
left a comment
Member
There was a problem hiding this comment.
Good catch. Some small changes are required, as well as adding a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.7.4.rst
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
michalsn
reviewed
Jun 11, 2026
michalsn
left a comment
Member
There was a problem hiding this comment.
Please fix the changelog entry.
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
michalsn
reviewed
Jun 12, 2026
Comment on lines
+36
to
38
| - **Session:** Fixed a bug in ``RedisHandler`` where the configured ``$lockRetryInterval`` and ``$lockMaxRetries`` values were not respected when acquiring session locks. | ||
| - **Model:** Fixed a bug in ``Model::objectToRawArray()`` where the ``$recursive`` parameter was ignored. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
RedisHandler::lockSession(), there was a bug where a hardcoded value of300was used to check if the maximum lock acquisition attempts were reached:This bypassed the actual
$this->lockMaxRetriesproperty configured by the user. As a result, if a developer configured a smallerlockAttemptslimit (e.g.,3), the check would fail to trigger because3 !== 300, causing the method to incorrectly returntrue(success) despite not acquiring the lock. Conversely, it would hardcode the failure point to exactly300attempts regardless of higher configurations.This PR replaces the hardcoded
300with$this->lockMaxRetriesin the condition and the associated error log message, ensuring the configured limits are appropriately enforced. A test has also been added to verify that the failure condition is triggered correctly after the maximum configured attempts.Checklist: