Bump actions/setup-node from 6 to 7 - #1885
Merged
Merged
Conversation
Recreates dependabot PR #1876 on an in-repo branch. Dependabot-triggered runs resolve secrets from the Dependabot secret store rather than the Actions store, so secrets.ADO_NPM_FEED_TOKEN came through empty and every job running `npm ci` failed with npm E401. The repo .npmrc points `registry=` at the codat-npm ADO feed, so a missing credential breaks the whole install, not just @codat/sdk-link-types. setup-node@v7 itself is fine — it ran green on the dependabot branch; only the subsequent install step failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Link check results: |
|
pmckinney-codat
enabled auto-merge
August 17, 2026 11:20
brucepouncey
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates #1876 on an in-repo branch so CI can actually authenticate.
Why #1876 can't pass
Dependabot-triggered runs resolve
secrets.*from the Dependabot secret store, not the Actions store.ADO_NPM_FEED_TOKENisn't reaching the runner from there, so the auth step wrote a blank_passwordinto~/.npmrcand every job runningnpm cidied with:The repo
.npmrcsetsregistry=to the codat-npm ADO feed for all packages, so a missing credential breaks the entire install rather than just@codat/sdk-link-types.spell-checkwas the only green check because it doesnpm install -g cspellfrom public npmjs and never touches the feed.Confirmed by rerunning #1876's failed jobs today — still E401, still
actor=dependabot[bot].The bump is sound
On #1876's branch the
Setup Node.jsstep (i.e.setup-node@v7) succeeded, npm cache included; only the following install step failed. This branch carries the identical 5-line change, off currentmain.Still outstanding
This unblocks the bump but not the cause — the Dependabot copy of
ADO_NPM_FEED_TOKENneeds setting to the current base64 value, or the next Dependabot PR here fails the same way.Closes #1876.
— Raised by Claude on Phil's behalf