Skip to content

fix openstack-placement with nixpkg update - #33

Merged
hertrste merged 1 commit into
mainfrom
fix-os-placement
Aug 3, 2026
Merged

fix openstack-placement with nixpkg update#33
hertrste merged 1 commit into
mainfrom
fix-os-placement

Conversation

@pkr4711

@pkr4711 pkr4711 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

python workaround must be removed after nixpkg
update from 2026-06-08 -> 2026-07-30

Summary by CodeRabbit

  • Chores
    • Simplified package test execution by running tests directly for more efficient test runs.

@pkr4711
pkr4711 requested a review from hertrste July 31, 2026 12:59
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: df978eae-aec3-44f5-b983-acf6fcef485d

📥 Commits

Reviewing files that changed from the base of the PR and between a745902 and 57dc054.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/openstack-placement.nix
💤 Files with no reviewable changes (1)
  • packages/openstack-placement.nix

📝 Walkthrough

Walkthrough

The package test phase no longer modifies the test file. Tests now run directly with stestr run.

Changes

Cohort / File(s) Summary
Placement test execution
packages/openstack-placement.nix
Removes the substitution that changed the expected "choose from 'db'" text before running stestr run.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: hertrste

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references fixing openstack-placement for a nixpkg update, which aligns with the PR objective to update the package for the Nixpkgs update from 2026-06-08 to 2026-07-30.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-os-placement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

python workaround must be removed after nixpkg
update from 2026-06-08 -> 2026-07-30

Signed-off-by: Paul Kroeher <paul.kroeher@cyberus-technology.de>
On-behalf-of: SAP paul.kroeher@sap.com
@pkr4711
pkr4711 force-pushed the fix-os-placement branch from a745902 to 57dc054 Compare July 31, 2026 14:09
@hertrste
hertrste merged commit d8585da into main Aug 3, 2026
8 checks passed
@hertrste
hertrste deleted the fix-os-placement branch August 3, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants