fix: verify Cloudsmith downloads at the raw versions path - #12
Merged
Conversation
The published files are served at raw/versions/<version>/<file>, not the raw/names path the verify step used, so a green publish failed on a 404. The download is also captured to a file first, so a failed download now hits the skip notice instead of hashing an empty stream and reporting a spurious checksum mismatch. Documents the served URLs in the README and folds the shipped publish job into the 0.1.0 changelog section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the release workflow’s Cloudsmith verification step to check the actual served download path (raw/versions/<version>/<file>), aligns the README examples with the stable served URLs, and updates the changelog to reflect the verification fix under Unreleased.
Changes:
- Update release workflow verification URLs to
raw/versions/<version>/<file>and download to disk before hashing. - Update README install + pinned/verified download URLs to
https://install.cloudsmith.com/raw/versions/.... - Update CHANGELOG to fold the publish job into
0.1.0and record this verification fix under Unreleased.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates documented Cloudsmith URLs to the served raw/versions/... endpoints for latest and pinned downloads. |
| CHANGELOG.md | Records the verification-path fix under Unreleased and consolidates the 0.1.0 release notes. |
| .github/workflows/release.yml | Fixes the verification download path and avoids hashing an empty stream by downloading to a file first. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v0.1.0 release run published
cli.sh,cli.ps1, andSHA256SUMSto Cloudsmith successfully, but the verify step then failed: it checkedraw/names/<name>/versions/<version>/<name>, while the files are actually served atraw/versions/<version>/<file>(confirmed live on bothdl.cloudsmith.ioandinstall.cloudsmith.com).raw/versions/<version>/<file>path.https://install.cloudsmith.com/raw/versions/latest/cli.sh) for both the one-command install and pinned/verified downloads.Validation
zizmor --pedantic: no findingsbats tests/install.bats: 39/39raw/versions/{0.1.0,latest}URLs verified returning the published content🤖 Generated with Claude Code