Skip to content

fix: address sidenav style changes for one theme#4697

Merged
mxschll merged 3 commits into
mainfrom
dev-v3-schomax-p0s
Jul 7, 2026
Merged

fix: address sidenav style changes for one theme#4697
mxschll merged 3 commits into
mainfrom
dev-v3-schomax-p0s

Conversation

@mxschll

@mxschll mxschll commented Jul 6, 2026

Copy link
Copy Markdown
Member

Description

Adresses side nav style changes for one theme.

Related links, issue #, if available: n/a

How has this been tested?

Locally.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.57%. Comparing base (45502c0) to head (938e4d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4697   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         948      948           
  Lines       30507    30509    +2     
  Branches    11164    11164           
=======================================
+ Hits        29767    29769    +2     
- Misses        693      733   +40     
+ Partials       47        7   -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll marked this pull request as ready for review July 6, 2026 14:43
@mxschll mxschll requested a review from a team as a code owner July 6, 2026 14:43
@mxschll mxschll requested review from NathanZlion and removed request for a team July 6, 2026 14:43
Comment thread src/side-navigation/styles.scss Outdated
@NathanZlion NathanZlion force-pushed the dev-v3-schomax-p0s branch from b8c084c to 938e4d1 Compare July 7, 2026 08:44

@NathanZlion NathanZlion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxschll mxschll added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit b497531 Jul 7, 2026
122 of 189 checks passed
@mxschll mxschll deleted the dev-v3-schomax-p0s branch July 7, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants