feat: Add filtering to button dropdown#4637
Open
avinashbot wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4637 +/- ##
==========================================
+ Coverage 97.57% 97.60% +0.02%
==========================================
Files 948 950 +2
Lines 30507 30632 +125
Branches 11164 11224 +60
==========================================
+ Hits 29767 29898 +131
- Misses 693 727 +34
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0d5d891 to
14e5718
Compare
14e5718 to
b0fd947
Compare
042705d to
50e2c55
Compare
50e2c55 to
d5f7211
Compare
71b731a to
3371c37
Compare
3371c37 to
7fe6f1d
Compare
7fe6f1d to
41d00ba
Compare
41d00ba to
17f2654
Compare
17f2654 to
f0e34d7
Compare
edb620f to
2aeec5f
Compare
2aeec5f to
85a8449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Button dropdown action filtering implemented a similar way to select/multiselect filtering. The big underlying change is that filtering requires the use of
aria-activedescendantrather than simply moving focus from item to item. So most of the internal changes are about disabling focusing logic when filtering is active, so that the real focus can stay on the input (and "accessibility" focus can move around usingaria-activedescendant).Rel: AWSUI-61960 (Chorus: qodG8KXdJXXk)
How has this been tested?
Updated unit tests, a bit of manual accessibility testing, but more validation with other screen readers is needed.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.