Skip to content

fix(ui): fix and improve some test descriptions#1806

Open
franzheidl wants to merge 6 commits into
mainfrom
franz-fix-test-descriptions-1590
Open

fix(ui): fix and improve some test descriptions#1806
franzheidl wants to merge 6 commits into
mainfrom
franz-fix-test-descriptions-1590

Conversation

@franzheidl

@franzheidl franzheidl commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

This PR fixes test descriptions in ui-components as per #1590.

Changes Made

  • Fix Radio test descriptions
  • Fix GridColumntest descriptions
  • Fix typos in TopNavigationItem
  • Fix FormattedText test descriptions
  • Fix Toast test descriptions
  • Fix Select test descriptions
  • Fix SelectDivider test descriptions
  • Fix ModalFooter test descriptions
  • Swap FormRow.test.tsx and FormSection.test.tsx files / file contents

Related Issues

Closes #1590

Test Instructions

  1. pnpm i
  2. pnpm run test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: Franz Heidl <franzheidl@sap.com>
@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 265a1a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

🚀 View preview at
https://cloudoperators.github.io/juno/pr-preview/pr-1806/

Built to branch gh-pages at 2026-07-03 11:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Franz Heidl added 2 commits July 3, 2026 10:44
Signed-off-by: Franz Heidl <franzheidl@sap.com>
Signed-off-by: Franz Heidl <franzheidl@sap.com>
@franzheidl franzheidl self-assigned this Jul 3, 2026
Signed-off-by: Franz Heidl <franzheidl@sap.com>
@franzheidl franzheidl marked this pull request as ready for review July 3, 2026 10:24
@franzheidl franzheidl requested a review from a team as a code owner July 3, 2026 10:24
Copilot AI review requested due to automatic review settings July 3, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the correctness of ui-components unit tests by fixing misleading test descriptions, correcting copy/paste artifacts, and re-aligning FormRow / FormSection tests with the components they actually cover (per #1590).

Changes:

  • Corrected multiple test titles/strings across several components (typos, wrong component names, clearer wording).
  • Fixed FormattedText testids that were incorrectly copied from Pagination.
  • Reworked FormRow.test.tsx and FormSection.test.tsx so each file tests the correct component (and added additional FormSection title-related assertions).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/ui-components/src/components/TopNavigationItem/TopNavigationItem.test.tsx Fixes typos in test descriptions (“ToppNavigationItem” → “TopNavigationItem”).
packages/ui-components/src/components/SelectDivider/SelectDivider.test.tsx Fixes typo in test description (“pops” → “props”).
packages/ui-components/src/components/Select/Select.test.tsx Fixes typo in test description (“defgault” → “default”).
packages/ui-components/src/components/Radio/Radio.test.tsx Improves several test descriptions to consistently refer to Radio.
packages/ui-components/src/components/ModalFooter/ModalFooter.test.tsx Fixes typo in test description (“onComfirm” → “onConfirm”).
packages/ui-components/src/components/GridColumn/GridColumn.test.tsx Fixes incorrect component reference in test description (“Grid row” → “Grid column”).
packages/ui-components/src/components/FormSection/FormSection.test.tsx Moves/updates tests so the file validates FormSection behavior (including title rendering).
packages/ui-components/src/components/FormRow/FormRow.test.tsx Moves/updates tests so the file validates FormRow behavior.
packages/ui-components/src/components/FormattedText/FormattedText.test.tsx Fixes copied test ids (“my-pagination” → “my-formatted-text”).

Comment thread packages/ui-components/src/components/FormSection/FormSection.test.tsx Outdated
Comment thread packages/ui-components/src/components/FormSection/FormSection.test.tsx Outdated
Comment thread packages/ui-components/src/components/FormRow/FormRow.test.tsx Outdated
Comment thread packages/ui-components/src/components/Radio/Radio.test.tsx Outdated
Franz Heidl added 2 commits July 3, 2026 12:43
Signed-off-by: Franz Heidl <franzheidl@sap.com>
Signed-off-by: Franz Heidl <franzheidl@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](ui): fix and improve wrong and nonsensical test descriptions across components

2 participants