Migrate DigestHelperTest from MD5 to SHA-384 (FIPS 140-3 + NCS) - #355
Open
vkalapov wants to merge 1 commit into
Open
Migrate DigestHelperTest from MD5 to SHA-384 (FIPS 140-3 + NCS)#355vkalapov wants to merge 1 commit into
vkalapov wants to merge 1 commit into
Conversation
LMCROSSITXSADEPLOY-3224
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update
DigestHelperTestto useSHA-384instead ofMD5and update the expected digest values accordingly.Why
MD5 usage is flagged by security scanning tooling regardless of whether it appears in test or production code. SHA-384 satisfies both FIPS 140-3 and NCS MODERATE requirements.
No production code changes —
DigestHelperitself is algorithm-agnostic.LMCROSSITXSADEPLOY-3224