Fix orphaned v3 doc partials (#5184)#5189
Open
norman-abramovitz wants to merge 1 commit into
Open
Conversation
- Reference upgrade_guide/conceptual_changes/ports in index.html.md (the _ports.md partial was added but never linked in the manifest) - Remove unused api_resources/_route_mappings.erb (no manifest refs) - Rename get_assigned_isolation_segment.md.erb to add the leading underscore, matching the partial naming convention and its sibling _manage_isolation_segment.md.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5184. Implements the changes @philippthun outlined in the issue thread:
upgrade_guide/conceptual_changes/_ports.md— was added but never referenced by the manifest. Rather than removing it, this adds the missing line todocs/v3/source/index.html.mdso the Ports section is actually published.api_resources/_route_mappings.erb— removed; it has no manifest references.resources/spaces/get_assigned_isolation_segment.md.erb— renamed to_get_assigned_isolation_segment.md.erbto add the leading underscore, matching the partial naming convention and its sibling_manage_isolation_segment.md.erb.Docs-only change.
Closes #5184.
I have read and signed the Contributor License Agreement — [x]