add leftovers to on_failure.

[ramonskie]

make leftovers a function and make it reusable

we set leftovers on each on failure task. and hope that this will stop the resource leakages

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 402f36e8-92ee-4586-9330-bf1e272fca27

📥 Commits

Reviewing files that changed from the base of the PR and between 6b03602 and 64f95e5.

📒 Files selected for processing (2)

• ci/configure.sh
• ci/pipelines/bosh-bootloader.yml

---

Walkthrough

The CI configuration now renders the BOSH bootloader pipeline with ytt into a temporary file before invoking fly, then removes the file on exit. The pipeline defines a reusable GCP bbl-leftovers task helper and replaces inline task definitions with helper calls across GCP CF and GCP Concourse bump job plans, including additional failure and cleanup paths.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'add leftovers to on_failure' accurately describes the main change: adding leftovers cleanup to on_failure handlers, which is the primary modification across multiple job plans.
Description check	✅ Passed	The description explains the key changes: converting leftovers into a reusable function and applying it to on_failure tasks to prevent resource leakage, which directly relates to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch leftovers-func

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[aramprice]

Thanks for tackling this @ramonskie !

[Copilot]

Pull request overview

This PR refactors the Concourse pipeline to make the “leftovers” cleanup step reusable and adds it to additional failure paths, aiming to reduce leaked GCP resources. It also updates the pipeline configuration script to render the ytt-templated pipeline before calling fly set-pipeline.

Changes:

• Introduce a ytt leftovers_task(env_name, state_dir) function in the pipeline and replace duplicated leftovers task blocks with function calls.
• Add leftovers steps into multiple on_failure / cleanup sequences across the GCP CF + GCP Concourse bump-deployments jobs.
• Update ci/configure.sh to render the pipeline via ytt into a temp file and set the pipeline from the rendered output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
ci/pipelines/bosh-bootloader.yml	Adds a reusable ytt leftovers task and wires leftovers into several failure/cleanup paths.
ci/configure.sh	Renders the ytt-templated pipeline to a temp file before running fly set-pipeline.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.