CI - Internal Tests filter out drafts again - #5715
Open
bfops wants to merge 2 commits into
Open
Conversation
Collaborator
|
But why would we exclude drafts? |
Collaborator
Author
It's an easy escape hatch for "I mentioned this PR but didn't mean for it to be caught by the look-for-mentions" logic. It's less dramatic than closing the PR, or closing and opening a new one. We can keep drafts, but then we should announce it internally so people are aware, because I know at least a few people have used this escape hatch. |
Collaborator
|
I'm not sure I follow. If you didn't mean to mention a PR, can't you just remove the mention? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
#5657 changed the behavior so we include draft PRs when looking up corresponding private PRs. This fixes that to restore our "convert to draft" escape hatch.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
None 🤷