Remove submodule overhead if no submodules - #5713
Closed
joshua-spacetime wants to merge 3 commits into
Closed
Conversation
joshua-spacetime
force-pushed
the
joshua/fix/keynote-bench
branch
from
August 10, 2026 23:05
564195a to
0ac4e81
Compare
Collaborator
Author
|
So far, none of these changes have had any impact on the keynote bench throughput. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Before this change, every reducer call did the following:
ctx.db.ctx.as.This was true whether or not the module had any submodules, and this added meaningful overhead especially for high throughput workloads, such as the keynote benchmark.
Now if a module doesn't have any submodules, reducer calls take an early fast path. It directly selects the root reducer and resets only values that genuinely change each transaction.
API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing