Skip to content

build: pin ethnum to 1.5.3 - #5712

Open
shitcodebykaushik wants to merge 1 commit into
clockworklabs:masterfrom
shitcodebykaushik:fix/pin-ethnum-1.5.3
Open

build: pin ethnum to 1.5.3#5712
shitcodebykaushik wants to merge 1 commit into
clockworklabs:masterfrom
shitcodebykaushik:fix/pin-ethnum-1.5.3

Conversation

@shitcodebykaushik

Copy link
Copy Markdown

Description of Changes

Pins the workspace ethnum dependency to exactly 1.5.3. Versions before 1.5.3 rely on the representation of an error type that changed in newer Rust toolchains, which can break downstream users even though SpacetimeDB's pinned toolchain is unaffected.

The lockfile already resolved ethnum 1.5.3, so no lockfile update is required.

Fixes #5512.

API and ABI breaking changes

None.

Expected complexity level and risk

  1. This is a one-line workspace dependency constraint change to the version already present in Cargo.lock.

Testing

  • cargo metadata --locked --no-deps --format-version 1
  • cargo check --locked -p spacetimedb-sats -p spacetimedb-expr -p spacetimedb-table -p spacetimedb-memory-usage
  • cargo test --locked -p spacetimedb-sats -p spacetimedb-expr -p spacetimedb-table -p spacetimedb-memory-usage --lib
  • git diff --check

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update and pin ethnum to 1.5.3

2 participants