fix "accessor" name migrations - #5544
Open
Shubham8287 wants to merge 17 commits into
Open
Conversation
These tests verify that changing a table or column accessor_name in a module schema triggers ChangeTableAccessorName and ChangeColumnAccessorName steps. They currently fail because the auto-migration logic is not yet implemented.
Add ChangeTableAccessorName and ChangeColumnAccessorName step variants and their full execution pipeline: auto-migration planning, datastore mutations (updating st_table_accessor / st_column_accessor system tables and in-memory schema), rollback support, formatter rendering, and step execution handlers.
Shubham8287
marked this pull request as draft
July 15, 2026 11:17
Shubham8287
marked this pull request as ready for review
July 29, 2026 14:00
Shubham8287
changed the title
joshua-spacetime
left a comment
joshua-spacetime
left a comment
Collaborator
There was a problem hiding this comment.
What about databases that already have the wrong accessor names in the database? How are those repaired?
Contributor
Author
yeah , it does not address that. I'm not sure we should add automatic recovery for affected databases, since it would require running I also don't think there are many affected databases. Users have always had a way to revert the accessor names to get things working again. For users who couldn't figure that out, it's unlikely they're still using those modules, since the affected tables and indexes would have been unusable. |
joshua-spacetime
approved these changes
Aug 3, 2026
clockwork-labs-bot
enabled auto-merge
August 9, 2026 13:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes: #5132.
It makes migration to notice "accessor" name changes and update "st_*_accessor" tables accordingly.
Not doing so results in runtime panic as module depends on accessor names to use exposed ABIs.
API and ABI breaking changes
NA
Expected complexity level and risk
2
Testing
Tests has been added.