chore(shared): Add JSDocs coverage for domain verification ownership#8956
chore(shared): Add JSDocs coverage for domain verification ownership#8956LauraBeatris wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: 53f9993 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughJSDoc comments for organization domain verification and ownership types are reworded across ChangesOrganization Verification Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
⚔️ Resolve merge conflicts
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/types/organizationDomain.ts`:
- Around line 67-83: The JSDoc comments for the `txtRecordName` and
`txtRecordValue` fields are making overly specific timing guarantees that the
`string | null` type signature does not enforce. Revise the JSDoc for both
fields to soften the wording and avoid implying that these values are guaranteed
to be present only immediately after calling `prepareOwnershipVerification`.
Instead, use language that acknowledges the values may or may not be populated
depending on the current state, without making specific promises about timing.
Replace phrases like "Only present immediately after" with more flexible
language that aligns with what the type signature actually guarantees.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 167d2d3c-f5b0-4c13-80ca-28885f60db34
📒 Files selected for processing (2)
.changeset/bumpy-ways-brake.mdpackages/shared/src/types/organizationDomain.ts
ee8f1fc to
976dc37
Compare
|
I updated the changeset to be empty as updating comments doesn't require a patch version update! |
|
@alexisintech Once we release |
Description
This PR adds JSDocs coverage to the latest types updates for organization domain verification via TXT records ownership
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
datavserrors.organization-domain-verificationreference resolves to the correct typedoc page.