chore(shared,ui): Add telemetry event for flow steps#8951
Conversation
🦋 Changeset detectedLatest commit: 56719d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new ChangesFlow Step Telemetry
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
16c48a2 to
8377b13
Compare
164d104 to
c2212d3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/telemetry/events/flow-step.ts`:
- Around line 34-38: The spread of payload in the telemetry event payload object
allows external data to override the core flow-step fields (flow, step, and
timestamp). Reorder the properties in the payload object so that the spread of
payload comes first, followed by the explicit core fields (flow, step, and
timestamp) so that these critical telemetry fields take precedence and cannot be
overridden by any data in the payload parameter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: b8bab827-d791-4454-80d8-9457d04e4a9c
📒 Files selected for processing (4)
packages/shared/src/telemetry/events/flow-step.tspackages/shared/src/telemetry/events/index.tspackages/ui/src/components/ConfigureSSO/steps/ActivateStep.tsxpackages/ui/src/components/ConfigureSSO/steps/OrganizationDomainsStep.tsx
API Changes Report
Summary
@clerk/sharedCurrent version: 4.20.0 Subpath
|
f8e1093 to
fcf1b4c
Compare
fcf1b4c to
e3be4a3
Compare
e3be4a3 to
947b1ab
Compare
947b1ab to
928b34c
Compare
928b34c to
56719d3
Compare
Description
This PR adds a new telemetry event to track when a flow step gets mounted, so we can leverage it on multi step flows such as self-serve SSO.
We want to leverage those events to later query the average time between when the user lands on the first step and actually ends up activating the connection.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit