Pin tools to v0.8.36 to fix Citus docker publish pipeline (gated — do not merge yet)#380
Open
ihalatci wants to merge 3 commits into
Open
Pin tools to v0.8.36 to fix Citus docker publish pipeline (gated — do not merge yet)#380ihalatci wants to merge 3 commits into
ihalatci wants to merge 3 commits into
Conversation
tools v0.8.34 update_docker.read_postgres_versions() indexes postgres_14/15_version, which docker pkgvars no longer provides (pg18/17/16 only), causing a KeyError that breaks update_version.yml on a Citus version bump (e.g. 14.1). tools v0.8.36-dev5 reads only pg18/17/16, matching pkgvars. publish_docker.py is byte-identical v0.8.34..dev5, so the 4 publish workflows have no behavior change; only update_version.yml is functionally fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stable citusdata/tools v0.8.36 is now cut (tag 40cc1d5 -> commit 6090091). Its update_docker/publish_docker/common_tool_methods are byte-identical to v0.8.36-dev5, so this repin is behavior-neutral and converges the pin off the pre-release onto the stable tag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ihalatci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned
citusdata/toolsclone tag fromv0.8.34tov0.8.36-dev5in all 5 workflows that clonetools. This is a CI pin fix only — no application/image changes.Root cause
docker's
pkgvarsno longer definespostgres_14_version/postgres_15_version(it now provides onlypostgres_18/17/16). tools v0.8.34 (and v0.8.35)update_docker.read_postgres_versions()still indexesconfig["postgres_15_version"]andconfig["postgres_14_version"], so it raisesKeyError: 'postgres_15_version'against the currentpkgvars. That breaksupdate_version.ymlwhenever Citus is bumped (e.g. 14.1).tools v0.8.36-dev5 reads only
postgres_18/17/16, matchingpkgvarsexactly.Validation (side-effect-free)
Ran the exact
read_postgres_versionsbodies from both tags against docker's realpkgvars:pkgvarskeys present:postgres_18_version, postgres_17_version, postgres_16_versionKeyError: 'postgres_15_version'(root cause reproduced)('18.1', '17.6', '16.10'), no error (fix confirmed)Why v0.8.36-dev5 (a pre-release)?
The pg14/15 drop in
update_dockerexists only in tools tagsv0.8.36-dev..dev5. Stablev0.8.36is not cut yet (origin/develop still reads pg14/15).v0.8.36-dev5is the only existing tag whoseupdate_dockermatches docker'spkgvars.This PR pins a pre-release tag intentionally. Convergence follow-up: once stable
v0.8.36is cut (aftercitusdata/tools#409 → #410 merge), update these pinsv0.8.36-dev5→v0.8.36and then merge. Lead agent coordinates the tools version cut alongside the GitHub App token migration.Scope / safety
publish_docker.pyis byte-identicalv0.8.34..v0.8.36-dev5→ the 4 publish workflows (cron,on_manual,on_push,on_tag) have no behavior change; bumped only to keep one coherent pinned version. Onlyupdate_version.ymlis functionally fixed.hyperscale/(pg-12/13/14) — intentionally left as-is per maintainer decision; Citus version strings (VERSION=14.0.0,citus-14.0, etc.);GH_TOKEN→ GitHub App token (separate later phase). NoCHANGELOGedit.Files changed (tag bump only, 1 line each)
.github/workflows/publish_docker_images_cron.yml.github/workflows/publish_docker_images_on_manual.yml.github/workflows/publish_docker_images_on_push.yml.github/workflows/publish_docker_images_on_tag.yml.github/workflows/update_version.ymlCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>