Skip to content

fix(capture): prioritize creating typed note - #1671

Draft
chhoumann wants to merge 2 commits into
masterfrom
fix/1670-prioritize-create-note
Draft

fix(capture): prioritize creating typed note#1671
chhoumann wants to merge 2 commits into
masterfrom
fix/1670-prioritize-create-note

Conversation

@chhoumann

@chhoumann chhoumann commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

When a capture can create its destination, keep the explicitly labeled create action above fuzzy note matches. The typed title is now visible and selected, so plain Enter creates that exact note instead of silently choosing a partial match.

Exact existing note names still suppress the create action, and unlabeled custom-input suggesters retain their historical matches-first behavior.

Changes

  • Put labeled custom actions first in InputSuggester while preserving generic custom-input ordering.
  • Add focused regression coverage for a typed New note beside existing New note 01 and New note 02 matches.
  • Document the selected create row and Enter behavior as available in the next release.
  • Canonicalize the orb test temp root and skip Linux-only launcher assertions off Linux so the new master tests pass on macOS and Windows.

Testing / validation

  • Reproduced on current master in an isolated Obsidian 1.13.4 vault with QuickAdd 2.22.0, Capture to: Folder/, creation enabled, and 12 fuzzy-matching notes. The create action was item 13 and below the visible picker viewport; Enter selected Folder/New note 12.md.
  • Re-ran the exact flow after the fix. Create new note: New note was item 1, selected, visible, and showed the file-plus icon. Enter advanced to Issue 1670 capture -> Folder/New note.md and created that path with Captured: Issue 1670 captured content. Workspace leaves remained unchanged and Obsidian reported no runtime errors.
  • pnpm exec vitest run --config vitest.config.mts src/gui/InputSuggester/inputSuggester.test.ts src/engine/CaptureChoiceEngine.selection.test.ts (76 passed)
  • pnpm exec vitest run --config vitest.config.mts tests/orb-setup.test.ts (4 passed, 2 skipped on macOS)
  • pnpm run test (4,918 passed, 39 skipped)
  • pnpm run build-with-lint
  • pnpm run check (0 errors, 0 warnings)
  • pnpm --dir docs run build
  • git diff --check

Release / migration impact

User-facing capture-picker bug fix. No settings or data migration is required.

Checklist

  • PR title follows Conventional Commits.
  • Linked the related issue.
  • Noted release and migration impact.

Fixes #1670

@chhoumann chhoumann linked an issue Aug 13, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: acc95555-1671-4436-80e6-6ac6a7224af2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa2b5b2
Status: ✅  Deploy successful!
Preview URL: https://7efa80a8.quickadd.pages.dev
Branch Preview URL: https://fix-1670-prioritize-create-n.quickadd.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] "Create new file if it doesn't exist" doesn't seem to work

1 participant