fix(capture): prioritize creating typed note - #1671
Draft
chhoumann wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
fa2b5b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7efa80a8.quickadd.pages.dev |
| Branch Preview URL: | https://fix-1670-prioritize-create-n.quickadd.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a capture can create its destination, keep the explicitly labeled create action above fuzzy note matches. The typed title is now visible and selected, so plain Enter creates that exact note instead of silently choosing a partial match.
Exact existing note names still suppress the create action, and unlabeled custom-input suggesters retain their historical matches-first behavior.
Changes
InputSuggesterwhile preserving generic custom-input ordering.New notebeside existingNew note 01andNew note 02matches.mastertests pass on macOS and Windows.Testing / validation
masterin an isolated Obsidian 1.13.4 vault with QuickAdd 2.22.0,Capture to: Folder/, creation enabled, and 12 fuzzy-matching notes. The create action was item 13 and below the visible picker viewport; Enter selectedFolder/New note 12.md.Create new note: New notewas item 1, selected, visible, and showed the file-plus icon. Enter advanced toIssue 1670 capture -> Folder/New note.mdand created that path withCaptured: Issue 1670 captured content. Workspace leaves remained unchanged and Obsidian reported no runtime errors.pnpm exec vitest run --config vitest.config.mts src/gui/InputSuggester/inputSuggester.test.ts src/engine/CaptureChoiceEngine.selection.test.ts(76 passed)pnpm exec vitest run --config vitest.config.mts tests/orb-setup.test.ts(4 passed, 2 skipped on macOS)pnpm run test(4,918 passed, 39 skipped)pnpm run build-with-lintpnpm run check(0 errors, 0 warnings)pnpm --dir docs run buildgit diff --checkRelease / migration impact
User-facing capture-picker bug fix. No settings or data migration is required.
Checklist
Fixes #1670