line chart shadow option#561
Open
Kaienss wants to merge 322 commits into
Open
Conversation
* Add files via upload * Add files via upload
* Added property 'absolute' to Pie Chart If property absolute is added to PieChart (<PieChart absolute />) the values change from percentage to the absolute numbers. * Updated README.md
…it#97) 2) Refactor decimalPlaces in renderHorizontalLabels (easier to read). 3) Updated App.js and README.md to show use of yAxisLabel.
* Updated README.md * Add StackedBar Factor Added a factor to correct Vertical Labels * Create stackedbar-chart * Add StackedBarChart to index.js * Add StackedBarChart to README.md * Added stackedBar Var * Resolve Conflicts * Inverted Legend Inverted Legend that it fit to the StackedBar order. * Improve Y Value * Try to repair the wrong Tab size The first commit has a wrong Tab Size * Correct Label position when Stack is to small * fix lint errors, add example into the app
When the data is negative value in BarChart, the corresponding bar is rendered to downward from 0.
* Draw BarChart and LineChart from 0 * Add prop `fromZero` Add prop `fromZero` to BarChart and LineChart to render the charts from 0 not from the minimum value.
* update app.json to have sdkVersion if sdkVersion is not present, expo will use the latest version installed on the computer vs the one from package.json * update line-chart.js to fix onPress handler logic * change larger click circle to not rely on the fill to have opacity * remove Circles from View that were making them not show up in iOS
* Hide Horizontal and Vertical Labels * improve docs
* Add labels to progress chart * Refactoring to make this a non-breaking change
…hart-kit#141) * fix: update paths-js library version to fix pie chart with empty values * fix: fix NaN labels on pie charts with empty values
Please look into this and approve as I was not able to proceed or I will have to change the plugin thanks
Add center property to PieChart property table. Clean up JSX props styling.
…y' prop (chart-kit#446) Co-authored-by: kafka <kafka@yunio.com>
…Legend prop is passed (chart-kit#479)
Co-authored-by: Herman Starikov <Hermanstarikov@gmail.com>
Co-authored-by: Herman Starikov <Hermanstarikov@gmail.com>
Added one option to dataset shadowColor: similar to color, if not provided, shadow color for the dataset will be the same as the line color with useShadowColorFromDataset:true, if useShadowColorFromDataset:false, shadow color will be chartConfig.color. shadow color is applied with following priority. dataset.shadowColor -> dataset.color -> chartConfig.color
Hermanya
reviewed
Feb 8, 2022
| }; | ||
|
|
||
| getShadowColor = (dataset: Dataset, opacity: number) => { | ||
| return (dataset.shadowColor || dataset.color || this.props.chartConfig.color)(opacity); |
Contributor
There was a problem hiding this comment.
I feel like it should default to url(#fillShadowGradient..., to make this change backwards compatible
Hermanya
requested changes
Feb 8, 2022
Hermanya
left a comment
Hermanya
left a comment
Contributor
There was a problem hiding this comment.
this change looks like it would change behaviour for existing users
ghost
force-pushed
the
master
branch
3 times, most recently
from
bc0b8af to
096eeb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added one option to dataset
shadowColor: similar to color, if not provided, shadow color for the dataset will be the same as the line color with useShadowColorFromDataset:true,
if useShadowColorFromDataset:false,
shadow color will be chartConfig.color.
shadow color is applied with following priority.
dataset.shadowColor -> dataset.color -> chartConfig.color