fix: be consistent with casing of Ccp#25
Open
TrueBrain wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to compile this repository under Linux (as one does), I ran against the fact that it is a bit messy how files are named:
CCPCcpNow this on its own wouldn't be an issue, was it not that the
CMakeLists.txtsometimes refers to the "wrong" variant, causing Linux to go: "I don't know thisCCPMemoryTracker.cppyou are talking about".The fix could be in two ways:
CMakeLists.txtto pick the right variant.The side-effect of 2) is that other projects depending on this library also have to fix their casing; but given this library already failed to compile on a case sensitive filesystem, I assume that isn't that much of a problem :)
And yes, there are more compile issue on Linux in this repository (and I understand this library only targets Windows / MacOS); but, if you are interested, that is for another day :)
PS: Fix solution 1) would look something like this:
Much smaller. But doesn't remove the actual confusing CCP vs Ccp. Hence this PR. But I have no issues changing it into the above.
Full disclosure: I work for Fenris Creations, although I have no involved with the Carbon project. I work on this in my free time under my own name.