Skip to content

fix: be consistent with casing of Ccp#25

Open
TrueBrain wants to merge 1 commit into
carbonengine:mainfrom
TrueBrain:push-rqonqnsmoxro
Open

fix: be consistent with casing of Ccp#25
TrueBrain wants to merge 1 commit into
carbonengine:mainfrom
TrueBrain:push-rqonqnsmoxro

Conversation

@TrueBrain

Copy link
Copy Markdown

While trying to compile this repository under Linux (as one does), I ran against the fact that it is a bit messy how files are named:

  • Some are prefixed with CCP
  • Most are prefixed with Ccp

Now this on its own wouldn't be an issue, was it not that the CMakeLists.txt sometimes refers to the "wrong" variant, causing Linux to go: "I don't know this CCPMemoryTracker.cpp you are talking about".

The fix could be in two ways:

  1. only fix CMakeLists.txt to pick the right variant.
  2. what this PR does: rename all files / imports consistently to the variant most used.

The side-effect of 2) is that other projects depending on this library also have to fix their casing; but given this library already failed to compile on a case sensitive filesystem, I assume that isn't that much of a problem :)

And yes, there are more compile issue on Linux in this repository (and I understand this library only targets Windows / MacOS); but, if you are interested, that is for another day :)

PS: Fix solution 1) would look something like this:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4279b02..c06e7f1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -20,12 +20,12 @@ set(SRC_FILES
         CcpCore.cpp
         CCPAssert.cpp
         CCPCallstack.cpp
-        CCPDefines.cpp
+        CcpDefines.cpp
         CcpFileUtils.cpp
         CCPHash.cpp
         CCPMemory.cpp
         CCPMemoryTracker.cpp
-        CCPMemoryTrackerMutex.h
+        CcpMemoryTrackerMutex.h
         CcpProcess.cpp
         CcpSecureCrt.cpp
         CcpSemaphore.cpp

Much smaller. But doesn't remove the actual confusing CCP vs Ccp. Hence this PR. But I have no issues changing it into the above.


Full disclosure: I work for Fenris Creations, although I have no involved with the Carbon project. I work on this in my free time under my own name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant