Node.js: Clarify Consistent Return Values#2690
Open
sjvans wants to merge 5 commits into
Open
Conversation
BobdenOs
previously approved these changes
Jun 29, 2026
| inserted[0] // same row (materialized above) | ||
| ``` | ||
|
|
||
| For `UPDATE`, `UPSERT`, and `DELETE`, the array is reserved for rows returned by a SQL `RETURNING` clause — not yet supported, so currently always empty: |
Contributor
There was a problem hiding this comment.
I'm note sure if I understand this sentence.
What is described in the first part is how it should be but it's not yet supported? Or what is not yet supported if the first part is how it works?
Contributor
Author
There was a problem hiding this comment.
we will add support for returning, which allows to specify which data i want back (bundle roundtrips to db). that will be the content of the array. since we don't yet support returning, the array is always empty. but the "shape" of the result is now established, namely an array with a property affected: <number>
Contributor
There was a problem hiding this comment.
Suggested change
| For `UPDATE`, `UPSERT`, and `DELETE`, the array is reserved for rows returned by a SQL `RETURNING` clause — not yet supported, so currently always empty: | |
| For `UPDATE`, `UPSERT`, and `DELETE`, the array is reserved for rows returned by a SQL `RETURNING` clause. But `RETURNING` is not yet supported, so the array currently is always empty: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.