mirror-core: survive git's detached auto-gc during tmp cleanup#4
Merged
Conversation
update_cap failed with ENOTEMPTY on rmSync(.mirror_tmp): the pin fetch can spawn a detached auto-gc that still writes into .mirror_tmp/.git while the finally-cleanup deletes the tree. Disable auto-gc/maintenance on the clone and fetch, and retry the rm (maxRetries) as a belt-and-braces fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXSCVM7CSVZ3Yo9eM4cG6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
update caprun after merging #3 failed withENOTEMPTY: rmdir .mirror_tmpinscripts/mirror-core.js. Root cause: the new UPSTREAM_HEAD pin fetch can spawn a detached git auto-gc that is still writing into.mirror_tmp/.gitwhile thefinallycleanup deletes the tree.Changes
-c gc.auto=0 -c gc.autoDetach=false -c maintenance.auto=false).rmSyncwithmaxRetries/retryDelay) as a belt-and-braces fallback.run/input/coreto builder-abap2UI5-js@95e33a1 (current main incl. the merged ajson hand-port).Verification
npm run mirror_coreruns clean locally (stale-slot path exercised); assemble + jest were green on this mirror state.🤖 Generated with Claude Code
https://claude.ai/code/session_01RXSCVM7CSVZ3Yo9eM4cG6d
Generated by Claude Code