[FEATURE] Add named wind axes force properties and unify sign rules - #280
Open
BorniaPedro wants to merge 4 commits into
Open
[FEATURE] Add named wind axes force properties and unify sign rules#280BorniaPedro wants to merge 4 commits into
BorniaPedro wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 94.53% 94.44% -0.09%
==========================================
Files 47 47
Lines 9209 9260 +51
==========================================
+ Hits 8706 8746 +40
- Misses 503 514 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds named wind axes force and force coefficient read-only properties to
AirplaneandPanel, centralizes the scalar types vocabulary in_output_rendering, replaces manual component negations across the output modules, and documents named wind axes force definitions indocs/AXES_POINTS_AND_FRAMES.md.Motivation
Physical load quantities like induced drag and lift were previously re-derived at multiple sites across the output modules by manually negating raw wind axes x and z vector components. Centralizing these physical quantities into named properties on
AirplaneandPanelplaces load knowledge with the load classes, avoids repeated sign negation rules, and establishes a single canonical source for the scalar type vocabulary across visualization functions.Relevant Issues
Closes #262 .
Changes
induced_drag_W,side_force_W,lift_W,induced_drag_coefficient_W,side_force_coefficient_W, andlift_coefficient_W) toAirplane.induced_drag_W,side_force_W, andlift_W) toPanelusing existing slots.VALID_SCALAR_TYPESvocabulary in_output_rendering.pyand refactoredget_scalarsto query named panel properties.drawandanimate, along with data assembly inplot_results_versus_time, to reference the centralized constants and named properties.docs/AXES_POINTS_AND_FRAMES.md.Dependency Updates
None.
Change Magnitude
Minor: Small change such as a bug fix, small enhancement, or documentation update.
Checklist (check each item when completed or not applicable)
mainand is up to date with the upstreammainbranch.--in-place --black). See the style guide for type hints and docstrings for more details.pterasoftwarepackage use type hints. See the style guide for type hints and docstrings for more details.testspackage.testspackage.ascii-only,pre-commit-hooks, andzizmorGitHub actions.lintjob of theCIGitHub action.testjobs of theCIGitHub action.