Migrate local pipeline + non-release CI from dfx to icp-cli - #550
Migrate local pipeline + non-release CI from dfx to icp-cli#550Kamirus wants to merge 4 commits into
Conversation
…-cli Switch `npm run replica`/`deploy-local` and the corresponding ci.yml steps to icp-cli + pocket-ic; mops-test.yml now relies on `[toolchain].pocket-ic` in mops.toml instead of dfx. Production deploys (release.yml, deploy-staging, deploy-ic) and `dfx generate` for declarations stay on dfx. LANG-1311 Co-authored-by: Cursor <cursoragent@cursor.com>
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit 5180ff4 |
mops 1.0.0 (tested by setup-mops.yml and mops-test.yml matrix) only supports pocket-ic 4.0.0. Adding pocket-ic = 12.0.0 to root mops.toml breaks 'mops test' for old CLIs in those matrices. Keeps icp.yaml + ci.yml/package.json/vite migration; mops-test.yml stays on dfx for now. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request has had no activity for 30 days and has been marked as stale. It will be closed in 14 days unless there is new activity. Comment or push to keep it open, or add the |
|
There are CI failures: https://github.com/caffeinelabs/mops/actions/runs/28434607718/job/84257379064?pr=550#step:12:15 And also the CI uses prerequisites that are woefully outdated... |
What changes for users
Mops contributors:
npm run replica,npm run deploy-localandnpm startnow useicp-cli+pocket-icinstead ofdfx. Local dev requiresnpm install -g @icp-sdk/icp-cli @icp-sdk/ic-wasm(Node-based install, see icp-cli quickstart).ci.ymlinstallsicp-clialongsidedfxand exercises the new local pipeline end-to-end.What stays on dfx:
release.yml,npm run deploy-staging,npm run deploy-ic.npm run decl:cli(dfx generate) — switching toicp-bindgenwould generate a noisy churn diff incli/declarations/; deferred.mops-test.ymlandsetup-mops.ymlmatrices: they test againstmops@1.0.0, which only supports pocket-ic 4.0.0 and so can't pick up a newer[toolchain].pocket-icfrom this repo's mops.toml.dfx.jsonis kept so the production paths and external mops users are unaffected.End users of the
ic-mopsCLI itself: no change.Why
Reduce internal coupling to dfx ahead of broader migration (LANG-1311). Picks the safe, low-blast-radius targets first (local dev + ci.yml) and leaves mainnet-touching paths and old-CLI matrices alone.
How it was validated
Locally exercised the full chain on macOS:
vite.config.tsreads the new flat icp ids map ({ name: id }) forlocal, with a fallback to.dfx/local/canister_ids.jsonso anyone still on the dfx pipeline locally is unaffected during the transition.Notes
icp.yamlmirrorsdfx.json;cliandplay-frontenduse raw build/sync steps because the asset-canister recipe template only supports a singledir.mops-test.ymlvia[toolchain].pocket-ic = "12.0.0"in root mops.toml failed CI: the matrix testsmops@1.0.0, which errors with "Current Mops CLI only supports pocket-ic 4.0.0". Reverted in a follow-up commit on this PR.