[APS-19734] fix: harden .npmrc with supply-chain security directives#1128
Open
Rohannagariya1 wants to merge 1 commit into
Open
[APS-19734] fix: harden .npmrc with supply-chain security directives#1128Rohannagariya1 wants to merge 1 commit into
Rohannagariya1 wants to merge 1 commit into
Conversation
- Add ignore-scripts, strict-ssl, save-exact, engine-strict, legacy-peer-deps=false, audit-level=high - Preserve existing package-lock=true and lockfile-version=1 - Public repo: access=restricted intentionally omitted - Validated: npm install + npm test identical before/after (678 passing, 13 pre-existing failures unchanged); no install scripts in the dep tree, so ignore-scripts=true causes no regression Resolves: APS-19734 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: APS-19734
Issue
The repo's
.npmrcfailed the weekly supply-chain.npmrcaudit (SC-12282) — it contained onlypackage-lock=true/lockfile-version=1and was missing the required hardening directives.Root Cause
Missing npm hardening directives that protect against malicious lifecycle scripts, TLS downgrade, version drift, and incompatible engines.
Fix Applied
Added the 6 required directives, preserving the existing two lines:
This is a public repo, so
access=restrictedis intentionally omitted.ignore-scripts compatibility (the cypress-CLI concern)
This is the Cypress CLI tool, so we explicitly verified
ignore-scripts=truedoes not break install or tests:package.jsonhas nopreinstall/install/postinstallscripts.browserstack-locallazy-downloads theBrowserStackLocalbinary at runtime (first use), not via an npm install script — so blocking install scripts does not prevent the binary fetch.enginesfield, soengine-strict=trueis a no-op here.Testing (before vs after, clean
node_modules)npm installnpm test(mocha)The 13 failures are pre-existing (error-report / deleteZip / table-config / video-config suites) and the failing-test set is byte-identical before and after — confirmed via diff. No regression introduced by the directives.
Jira Ticket
https://browserstack.atlassian.net/browse/APS-19734
Checklist
npm install+npm testvalidated identical before/after.npmrcchange)