Skip to content

fix: remove deprecated brev recreate code implementation #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vivansh12 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −284
Draft

fix: remove deprecated brev recreate code implementation #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions docs/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

```
VERSION=unknown
BREV_API_URL=http://localhost:8080
BREV_API_URL=http://localhost:8080
# BREV_API_URL=<your backend>
```

Expand Down Expand Up @@ -89,15 +89,6 @@ index a33540c..b03d5f2 100644
func hasHousekeepingCommands(cmd *cobra.Command) bool {
```

test your function

```
make && ./brev recreate
```

add documentation by editing `pkg/cmd/recreate/doc.md`. Docs should fill out the
minimum fields:

```
<!-- Insert title here -->
#
Expand Down
2 changes: 0 additions & 2 deletions pkg/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import (
"github.com/brevdev/brev-cli/pkg/cmd/portforward"
"github.com/brevdev/brev-cli/pkg/cmd/profile"
"github.com/brevdev/brev-cli/pkg/cmd/proxy"
"github.com/brevdev/brev-cli/pkg/cmd/recreate"
"github.com/brevdev/brev-cli/pkg/cmd/redeem"
"github.com/brevdev/brev-cli/pkg/cmd/refresh"
"github.com/brevdev/brev-cli/pkg/cmd/register"
Expand Down Expand Up @@ -340,7 +339,6 @@ func createCmdTree(cmd *cobra.Command, t *terminal.Terminal, loginCmdStore *stor
cmd.AddCommand(healthcheck.NewCmdHealthcheck(t, noLoginCmdStore))

cmd.AddCommand(setupworkspace.NewCmdSetupWorkspace(noLoginCmdStore))
cmd.AddCommand(recreate.NewCmdRecreate(t, loginCmdStore))
cmd.AddCommand(writeconnectionevent.NewCmdwriteConnectionEvent(t, loginCmdStore))
cmd.AddCommand(updatemodel.NewCmdupdatemodel(t, loginCmdStore))
cmd.AddCommand(feedback.NewCmdFeedback(t, noLoginCmdStore))
Expand Down
46 changes: 0 additions & 46 deletions pkg/cmd/recreate/doc.md
View file
Open in desktop

This file was deleted.

226 changes: 0 additions & 226 deletions pkg/cmd/recreate/recreate.go
View file
Open in desktop

This file was deleted.

Loading